Skip to content

BridgeJS: Support generic functions on imported JS APIs - #799

Open
krodak wants to merge 2 commits into
swiftwasm:mainfrom
PassiveLogic:kr/stack-abi-generics-import
Open

BridgeJS: Support generic functions on imported JS APIs#799
krodak wants to merge 2 commits into
swiftwasm:mainfrom
PassiveLogic:kr/stack-abi-generics-import

Conversation

@krodak

@krodak krodak commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

Import half of generic function support (#398), split out of #787 per review. An imported @JSFunction can take a type parameter, so one declaration covers every bridged type:

@JSFunction func parse<T: BridgedSwiftGenericBridgeable>(_ json: String) throws(JSException) -> T

let user: User = try parse(jsonString)   // T inferred from the call site

T can be any primitive, String, JSValue, or a @JS struct/enum/final class, bare or as T?, [T], [String: T]. Also works on @JSClass inits, methods and statics, and for return-only generics. Exported generics are rejected with a diagnostic and land separately on top of this ABI.

How it works

  • Values cross on the existing stack ABI. The only new thing on the wire is an i32 type ID per type parameter, so type-agnostic JS glue can pick the right lift/lower.
  • Type IDs are pointer-based, not name-based (per BridgeJS: Support generic functions at the Swift and JavaScript boundary #787 review): each type gets a BridgeJSTypeHandle, its address is the ID. Same-named types in different modules can't collide, and no existentials means it works under Embedded.
  • Each module exports bjs_<Module>_register_type_handles, which hands its IDs to JS; JS pairs them with its codec table by index. Runs eagerly via a new afterInitialize instantiator hook, or lazily on first generic call (worker threads).
  • Conformances are emitted for every @JS type, not just in modules that declare generics, module B can pass module A's type to a generic function (per BridgeJS: Support generic functions at the Swift and JavaScript boundary #787 review).
  • JS containers get one shared codec each (__bjs_arrayCodec etc.); the non-generic array/dict/optional paths now reuse them instead of inlining a copy per thunk (per BridgeJS: Support generic functions at the Swift and JavaScript boundary #787 review on the stack ABI clones).

Builds without generics don't get the JS generic runtime, just a no-op registration hook per module with @JS types.

Test plan

  • Codegen + link snapshots: free functions, inits, methods, statics, mixed/multiple params, return-only, wrapped forms
  • Diagnostics: import constraints, export rejection
  • ImportGenericAPITests: runtime round-trip of every bridgeable type through real JS, including JSON.parse
  • Examples/Embedded builds a generic round-trip in CI
  • Cross-module registration + runtime gating link tests

@krodak krodak self-assigned this Aug 10, 2026
@krodak
krodak requested a review from kateinoigakukun August 10, 2026 14:13
Comment on lines +418 to +432
Bool.bridgeJSTypeID,
Int.bridgeJSTypeID,
Int8.bridgeJSTypeID,
UInt8.bridgeJSTypeID,
Int16.bridgeJSTypeID,
UInt16.bridgeJSTypeID,
Int32.bridgeJSTypeID,
UInt32.bridgeJSTypeID,
UInt.bridgeJSTypeID,
Int64.bridgeJSTypeID,
UInt64.bridgeJSTypeID,
Float.bridgeJSTypeID,
Double.bridgeJSTypeID,
String.bridgeJSTypeID,
JSValue.bridgeJSTypeID,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put those core type table entries in JavaScriptKit instead of defining in every module?

prefix: "const \(codecVar) = ",
suffix: ";"
)
return codecVar

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we define a codec helper instead of inlining them? I think we can define StackABI codec helpers for any type that can appear in those combinators' element positions. And it should be shared with the one in type table entries.

return jsValue;
}

const __bjs_createGenericPointHelpers = () => ({

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include the module name to allow name collisions across modules.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I reverted that change, will bring it back in a few 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants